Skip to content

fix(contrib): catch review assignment error#2092

Open
n1k0 wants to merge 2 commits intomasterfrom
fix/catch-log-gh-api-contrib-errors
Open

fix(contrib): catch review assignment error#2092
n1k0 wants to merge 2 commits intomasterfrom
fix/catch-log-gh-api-contrib-errors

Conversation

@n1k0
Copy link
Copy Markdown
Member

@n1k0 n1k0 commented Apr 15, 2026

This patch fixes a poorly worded error message rendered to users after a successful contrib when the github API fails assigning a team as reviewers. Note that we'll eventually have to find a better way to assign reviewers because right now the gh permission mechanism gets in the way in a nasty fashion.

@n1k0 n1k0 requested a review from vjousse April 15, 2026 21:43
@n1k0 n1k0 changed the title fix(contrib): catch review assignment error, gh api=hell fix(contrib): catch review assignment error Apr 16, 2026
@n1k0 n1k0 removed the request for review from vjousse April 16, 2026 08:48
@n1k0
Copy link
Copy Markdown
Member Author

n1k0 commented Apr 16, 2026

There are still issues I'll keep working on, hold on reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant